frontend/server/data/tinybird/forks-data-source.test.ts (3)

29-72: Add verification of parameters passed to the mock function

While the test correctly verifies the output structure, it doesn't verify that fetchFromTinybird was called with the correct parameters for each request.

Add expectations to verify the correct parameters were passed:

  expect(result).toEqual(expectedResult);
+ 
+ // Verify that fetchFromTinybird was called with correct parameters
+ expect(mockFetchFromTinybird).toHaveBeenCalledTimes(3);
+ expect(mockFetchFromTinybird.mock.calls[0][1]).toMatchObject({
+   project: 'the-linux-kernel-organization',
+   activityType: ActivityFilterActivityType.FORKS,
+ });

---

55-63: Calculate percentageChange dynamically instead of hardcoding

The percentageChange is hardcoded to 100, which may not accurately reflect the actual percentage change between the current and previous values.

  summary: {
    current: currentCumulativeCount,
    previous: previousCumulativeCount,
-   percentageChange: 100,
+   percentageChange: previousCumulativeCount === 0 
+     ? 0 
+     : ((currentCumulativeCount - previousCumulativeCount) / previousCumulativeCount) * 100,
    changeValue: currentCumulativeCount - previousCumulativeCount,
    periodFrom: filter.startDate?.toString(),
    periodTo: filter.endDate?.toString(),
  },

---

74-117: Similar issue with hardcoded percentageChange in the second test

Like in the first test, the percentageChange is hardcoded to 100 instead of being calculated based on the actual values.

  summary: {
    current: currentCumulativeCount,
    previous: previousCumulativeCount,
-   percentageChange: 100,
+   percentageChange: previousCumulativeCount === 0 
+     ? 0 
+     : ((currentCumulativeCount - previousCumulativeCount) / previousCumulativeCount) * 100,
    changeValue: currentCumulativeCount - previousCumulativeCount,
    periodFrom: filter.startDate?.toString(),
    periodTo: filter.endDate?.toString(),
  },

frontend/server/mocks/tinybird-forks-response.mock.ts (3)

41-129: Consider adding non-zero values to the cumulative timeseries data

All cumulative activity counts are set to 0, which might not test real-world scenarios effectively. For a better test, consider adding increasing values over time, which is expected behavior for cumulative metrics.

  {
    startDate: "2024-03-01",
    endDate: "2024-03-31",
-   cumulativeActivityCount: 0
+   cumulativeActivityCount: 10
  },
  {
    startDate: "2024-04-01",
    endDate: "2024-04-30",
-   cumulativeActivityCount: 0
+   cumulativeActivityCount: 25
  },
  {
    startDate: "2024-05-01",
    endDate: "2024-05-31",
-   cumulativeActivityCount: 0
+   cumulativeActivityCount: 40
  },

---

131-219: Add some non-zero values to new timeseries data

Like the cumulative data, the new activity counts are all set to 0. For more effective testing, consider adding varying (non-zero) values to ensure the visualization can handle peaks and trends.

  {
    startDate: "2023-03-01",
    endDate: "2023-03-31",
-   activityCount: 0
+   activityCount: 5
  },
  {
    startDate: "2023-04-01",
    endDate: "2023-04-30",
-   activityCount: 0
+   activityCount: 12
  },
  {
    startDate: "2023-05-01",
    endDate: "2023-05-31",
-   activityCount: 0
+   activityCount: 8
  },

---

1-219: Consider creating a mock data factory function

The mock objects share similar structures but with different field names and values. Consider creating a factory function to generate these mock objects to reduce duplication and make it easier to create varied test cases.

function createTimeseriesMock(options: {
  field: string;
  startYear: number;
  startMonth: number;
  count: number;
  values?: number[];
}) {
  const { field, startYear, startMonth, count, values = [] } = options;
  const data = [];
  
  for (let i = 0; i < count; i++) {
    const currentMonth = ((startMonth - 1 + i) % 12) + 1;
    const yearOffset = Math.floor((startMonth - 1 + i) / 12);
    const year = startYear + yearOffset;
    
    // Calculate days in month
    const daysInMonth = new Date(year, currentMonth, 0).getDate();
    
    data.push({
      startDate: `${year}-${String(currentMonth).padStart(2, '0')}-01`,
      endDate: `${year}-${String(currentMonth).padStart(2, '0')}-${daysInMonth}`,
      [field]: values[i] || 0
    });
  }
  
  return {
    meta: [
      { name: "startDate", type: "Nullable(Date)" },
      { name: "endDate", type: "Nullable(Date)" },
      { name: field, type: field.includes("cumulative") ? "Nullable(UInt64)" : "UInt64" }
    ],
    data,
    rows: data.length,
    statistics: {
      elapsed: 0.123456789,
      rows_read: 100000,
      bytes_read: 5000000
    }
  };
}

// Example usage:
export const mockCurrentCumulativeTimeseries = createTimeseriesMock({
  field: "cumulativeActivityCount",
  startYear: 2024,
  startMonth: 3,
  count: 13,
  values: [10, 25, 40, 60, 75, 90, 105, 120, 135, 150, 165, 180, 200]
});

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Learnt from: borfast
PR: LF-Engineering/insights#76
File: frontend/server/data/tinybird/active-contributors-data-source.test.ts:10-10
Timestamp: 2025-03-27T11:19:30.505Z
Learning: The tests in the frontend/server/data/tinybird directory became broken due to changes introduced in another branch and will need to be revisited later as part of the data sources refactoring.